Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V3-image-section #998

Merged
merged 4 commits into from
Dec 12, 2024
Merged

V3-image-section #998

merged 4 commits into from
Dec 12, 2024

Conversation

anemne
Copy link
Contributor

@anemne anemne commented Dec 11, 2024

This PR simplifies existing image section by removing title and changes the size and width of the image.

Screenshot 2024-12-11 at 15 35 21 Screenshot 2024-12-11 at 15 35 28 Screenshot 2024-12-11 at 15 35 38 Screenshot 2024-12-11 at 15 35 46

@vercel Vercel
Copy link

vercel bot commented Dec 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
variant-no ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 4:09pm
variant-se-2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 4:09pm

idamand
idamand reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@idamand idamand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove title from schema too? :)

@anemne
Copy link
Contributor Author

anemne commented Dec 11, 2024

Should we remove title from schema too? :)

Yesss

@anemne anemne requested a review from idamand December 11, 2024 16:06
idamand
idamand approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@idamand idamand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌

@anemne anemne merged commit 9005775 into v3 Dec 12, 2024
6 checks passed
@anemne anemne deleted the v3-image-section branch December 12, 2024 08:14
@anemne anemne mentioned this pull request Dec 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idamand idamand idamand approved these changes

@mikaelbr mikaelbr Awaiting requested review from mikaelbr

@petterhh petterhh Awaiting requested review from petterhh

@trulshj trulshj Awaiting requested review from trulshj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anemne @idamand